Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a PIP workspace for colcon and vcs #493

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Conversation

j-rivero
Copy link
Contributor

@j-rivero j-rivero commented Sep 2, 2024

🦟 Bug fix

Related to gazebosim/gazebo_test_cases#1699 (comment)

Summary

Remove a good bunch of pip instructions in favor of using a workspace with a simplification of the installation.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@azeey azeey merged commit d38f73a into master Sep 3, 2024
6 checks passed
@azeey azeey deleted the jrivero/colcon_vcs_pip_ws branch September 3, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants